Support conda envs without changeps1 #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most people have conda add the current env name to PS1. This breaks the parsing of PS1, and in particular prevents bash_kernel doing `echo $?` to find if the previous command succeeded. This change makes the PS1 expect string a regex that allows for the `(envname) ` which conda adds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most people have conda add the current env name to PS1. This breaks the parsing of PS1, and in particular prevents bash_kernel doing
echo $?to find if the previous command succeeded.This change makes the PS1 expect string a regex that allows for the
(envname)which conda adds.Making this in a PR so @takluyver has a chance to review/veto it before it it hits
main.Dear users: if you want to test this now, please install from my dev branch that contains this and the other concurrent PR: