Unable to include Holidays

[mleden]

I would like to include the "Holidays" feature in my GANTT. However, I cannot seem to make that work and I see no difference in the rendering of any samples use this directive.
To include Christmas Day for 2012, I tried this:
...
holidays: ["/Date('December 25, 2012')/"],
...
I did not see anything different in the GANTT whether or not I included this directive. Nor did I see any errors in the browser console (Chrome on WinXP).

Any ideas where I am going wrong?

TIA,
-Mark

[versak]

The date is in milliseconds:
holidays: [
"/Date(1293836400000)/"
]

[mleden]

Thanks for the info on using milliseconds. The problem (I have with that) is that I am pulling all of the date information for the Gantt out of a MySQL DB (actually multiple DBs). In order to use the date values directly in the JSON, I could simply wrap those with the Date() function, like Date('12-31-2013') for the the last day of 2013. I did not have to convert any of these DB values to milliseconds. So, it seems inconsistent, not to mention inconvenient and more complicated to have to do that with my vacation values. Or am I missing something?

Thx,
-Mark

[usmonster]

@mleden There seems to not be a bug here, but a feature request, is this correct?

[mleden]

@usmonster I would classify this as a bug, although it could be user error on my part. Basically, I have a nicely working Gantt which draws all of its date information out of multiple MySQL databases. In order to use the date values directly in the JSON, I simply wrap those with the Date() function, like Date('12-31-2013') for the the last day of 2013. This works fine for rendering the Gantt bars themselves. However, if I try a similar approach with the "Holidays" data -- see my original posting for the exact syntax -- the Holidays are NOT rendered.
Bottomline, it seems that some of the JSON data consumed by the plugin REQUIRES it to be in milliseconds while other data does not. Or am I missing something?

Thx,
-Mark

[usmonster]

@mleden You are correct that the plugin requires the millisecond format to work, as it is documented here:
http://taitems.github.io/jQuery.Gantt/

Otherwise the behavior is undefined (which means it may even change over time). The fact that the rest of the plugin appears to work with strings like '12-31-2013' is just coincidental, but dangerous behavior to rely upon, as it is not documented or acknowledged by the plugin authors. (It may also not work as expected in all browsers-- see http://dygraphs.com/date-formats.html .)

The holiday-related code is actually expecting the required millisecond format, so changing this behavior seems more like a feature request to me.

Does this make sense?

[usmonster]

@mleden, you might be interested in #93, which should make the date handling more consistent throughout the plugin, thereby fixing this issue (I think). The pull request is still being reviewed, but you can test it to see if it works for you.

[taitems]

Closed in #93