Add open, onOpen, onClose props to Menu component #1966
Closed
+106
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to control Menu visibility from the outside, using a prop and callbacks, opens up a lot of possibilities.
For example, one can use the Menu without a Button trigger as a context menu, while keeping all the great accessibility features
@headlessui/menuprovides.It fixes #649, #1937 and similar PR for Popover will fix #828
I know you normally don't accept PRs from the outside, but since I'll be keeping the fork up to date for our internal usage, I thought it's worth considering.
Vue implementation is missing as I'm not fluent in Vue, but I think the implementation should be just as straightforward as for React.