refactor(test/utils): simplify storage prices configuration in gasUtils #3437
Conversation
| import "@ton/test-utils"; | ||
| import { cached } from "@/test/utils/cache-state"; | ||
| import { setStoragePrices } from "@/test/utils/gasUtils"; | ||
| import { zeroStoragePrices } from "@/test/utils/gasUtils"; |
There was a problem hiding this comment.
I'd name this function using the verb as the first word.
What about removeStorageFee or something like that?
There was a problem hiding this comment.
turnOffStorageFee or skipStorageFee would be some other alternatives
Kaladin13
left a comment
Kaladin13
left a comment
There was a problem hiding this comment.
LGTM modulo version bump
|
@skywardboundd merge conflicts :) |
|
Resolved merge conflicts |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export function zeroStoragePrices(configRaw: Cell): Cell { | ||
| return setStoragePrices(configRaw, { | ||
| kind: "StoragePrices", | ||
| utime_since: 0, | ||
| bit_price_ps: 0n, | ||
| _cell_price_ps: 0n, | ||
| mc_bit_price_ps: 0n, | ||
| mc_cell_price_ps: 0n, |
There was a problem hiding this comment.
The new zeroStoragePrices helper constructs a StoragePrices object with _cell_price_ps. The generated type in @ton/sandbox/dist/config/config.tlb-gen exposes this property as cell_price_ps (no leading underscore). Because the required field is missing, TypeScript will reject the call to setStoragePrices, so any test importing this helper fails to compile. Use the correct field name when building the StoragePrices object.
Useful? React with 👍 / 👎.
Closes #3436