Skip to content

Conversation

@novusnota
Copy link
Member

Issue

Closes #3198.

@novusnota novusnota added this to the Doc: 2025-05 milestone May 21, 2025
@novusnota novusnota requested a review from a team as a code owner May 21, 2025 11:10
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes look like those methods are static, but they are not. We should just remove the dots.

@novusnota
Copy link
Member Author

All these changes look like those methods are static, but they are not. We should just remove the dots.

Not really. Cell, Builder and Slice before the dot and the name of the extension function are ubiquitous and used across the docs.

Sure, static methods would look identical to regular methods (extension functions), but at least it's clear that those are methods and not global functions. And we don't have many static methods for that to be a problem anyways.

Copy link
Member Author

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD: Whoops, didn't mean to comment

@novusnota novusnota requested a review from anton-trunov May 30, 2025 09:46
@anton-trunov anton-trunov merged commit 0f64dea into main Jun 9, 2025
23 checks passed
@anton-trunov anton-trunov deleted the closes-3198 branch June 9, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider adding self as .reply() is confusing

3 participants