Minor: remove an unecessary clone in common_sort_prefix_length #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 3, 2025
| // If the ordering vanishes after normalization, it is satisfied: | ||
| return Ok((vec![], true)); | ||
| }; | ||
| let prefix_len = self.common_sort_prefix_length(normal_ordering.clone())?; |
There was a problem hiding this comment.
The point of this PR is to remove this clone
berkaysynnada
merged commit 1aebf24
into
synnada-ai:required-input-ordering
1 check passed
|
Thank you @alamb ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor suggestion that trgets apache#16217 and avoids a clone
Merging it will update apache#16217