Skip to content

I249- Fix AreaSeries Y-Axis Rendering Issue in .NET MAUI Chart. #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2025
Merged

I249- Fix AreaSeries Y-Axis Rendering Issue in .NET MAUI Chart. #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e806730
Remove the ymin value from AreaSegment setdata method
aruljenithberkmans Aug 28, 2025
7ffe207
Merge branch 'syncfusion:main' into main
aruljenithberkmans Sep 11, 2025
985f4f0
Update missed Unit test cases
aruljenithberkmans Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions maui/src/Charts/Segment/AreaSegment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,6 @@ internal override void SetData(IList xValues, IList yValues)

var yMin = YValues.Min();
yMin = double.IsNaN(yMin) ? YValues.Length > 0 ? YValues.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : yMin;
var start = series.ActualYAxis.VisibleRange.Start;
yMin = yMin == 0 ? (double.IsNaN(start) ? yMin : start) : yMin;

Empty = double.IsNaN(yMin);

Expand Down
2 changes: 0 additions & 2 deletions maui/src/Charts/Segment/PolarAreaSegment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ internal override void SetData(IList xDatas, IList yDatas)
yDatas.CopyTo(_yValues, 0);
var yMin = _yValues.Min();
yMin = double.IsNaN(yMin) ? _yValues.Length > 0 ? _yValues.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : yMin;
var start = series.ActualYAxis.VisibleRange.Start;
yMin = yMin == 0 ? (double.IsNaN(start) ? yMin : start) : yMin;
series.XRange += new DoubleRange(_xValues.Min(), _xValues.Max());
series.YRange += new DoubleRange(yMin, _yValues.Max());
}
Expand Down
2 changes: 0 additions & 2 deletions maui/src/Charts/Segment/SplineAreaSegment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,6 @@ void UpdateRange()
{
_minY = YVal.Min();
_minY = double.IsNaN(_minY) ? YVal.Length > 0 ? YVal.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : _minY;
var start = series.ActualYAxis.VisibleRange.Start;
_minY = _minY == 0 ? (double.IsNaN(start) ? _minY : start) : _minY;
_maxY = YVal.Max();

double startControlMin = ControlStartY.Min();
Expand Down
2 changes: 0 additions & 2 deletions maui/src/Charts/Segment/SplineRangeAreaSegment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,6 @@ void UpdateRange()
{
_min = HighVal.Min();
_min = double.IsNaN(_min) ? HighVal.Length > 0 ? HighVal.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : _min;
var start = series.ActualYAxis.VisibleRange.Start;
_min = _min == 0 ? (double.IsNaN(start) ? _min : start) : _min;
_max = HighVal.Max();

if (HighControlStartY != null && HighControlEndY != null)
Expand Down
2 changes: 0 additions & 2 deletions maui/src/Charts/Segment/StackingAreaSegment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ internal void SetData(IList xValues, IList yEnds, IList yStarts)

var yMin = TopValues.Min();
yMin = double.IsNaN(yMin) ? TopValues.Length > 0 ? TopValues.Where(e => !double.IsNaN(e)).DefaultIfEmpty().Min() : 0 : yMin;
var start = series.ActualYAxis.VisibleRange.Start;
yMin = yMin == 0 ? (double.IsNaN(start) ? yMin : start) : yMin;

Series.XRange += new DoubleRange(XValues.Min(), XValues.Max());
Series.YRange += new DoubleRange(yMin, TopValues.Max());
Expand Down
10 changes: 5 additions & 5 deletions maui/tests/Syncfusion.Maui.Toolkit.UnitTest/Chart/Features/ChartFeatureAxisUnitTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1534,7 +1534,7 @@ public void AddSmallTicksPoint_ShouldAddCorrectNumberOfSmallTicks()
}

[Theory]
[InlineData(0, 100, 1)]
[InlineData(0, 100, 20)]
[InlineData(0, 365, 2)]
public void CalculateNiceInterval_ShouldReturnCorrectInterval(double start, double end, double expectedInterval)
{
Expand Down Expand Up @@ -1604,7 +1604,7 @@ public void OnMinMaxChanged_ShouldUpdateActualRangeWithMinMaxValues_WhenMinMaxAr
[InlineData(DateTimeIntervalType.Years, 0.1)]
[InlineData(DateTimeIntervalType.Months, 1)]
[InlineData(DateTimeIntervalType.Days, 50)]
[InlineData(DateTimeIntervalType.Hours, 1000)]
[InlineData(DateTimeIntervalType.Hours, 500)]
[InlineData(DateTimeIntervalType.Minutes, 50000)]
[InlineData(DateTimeIntervalType.Seconds, 2000000)]
public void CalculateDateTimeIntervalType_ShouldReturnCorrectInterval_ForGivenIntervalType(DateTimeIntervalType intervalType, double expectedInterval)
Expand Down Expand Up @@ -2062,8 +2062,8 @@ public void CalculateActualRange_ReturnsExpectedRange(double defaultMin, double
}

[Theory]
[InlineData(double.NaN, 10)]
[InlineData(0, 10)]
[InlineData(double.NaN, 5)]
[InlineData(0, 5)]
[InlineData(5, 5)]
public void CalculateActualInterval_ReturnsExpectedInterval(double axisInterval, double expected)
{
Expand All @@ -2081,7 +2081,7 @@ public void CalculateActualInterval_ReturnsExpectedInterval(double axisInterval,
}

[Theory]
[InlineData(1, 10, 100, 10)]
[InlineData(1, 10, 100, 5)]
[InlineData(1, 1000, 100, 1000)]
[InlineData(1, 1000, 10, 1000)]
public void CalculateNiceInterval_ReturnsExpectedInterval(double rangeStart, double rangeEnd, int availableWidth, double expected)
Expand Down