Fix SegmentBackground not being drawn when StrokeThickness is set to 0 #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
StrokeThicknessis set to 0 onSfSegmentedControl, theSegmentBackgroundcolor disappears and becomes virtually transparent, even when explicitly set to a color.Expected: Red background with no border stroke
Actual: Transparent background
Root Cause
In
SegmentItemView.DrawRoundedRectangle(), the method had an early return condition that prevented drawing whenStrokeThickness == 0:Solution
Modified the drawing logic to:
SegmentBackgroundis setStrokeThickness > 0Key Changes
StrokeThickness == 0from early return conditionBefore/After
Before:
After:
Testing
Added comprehensive test cases to verify:
SegmentBackgroundproperty is preserved whenStrokeThickness = 0GetSegmentBackground()helper returns correct values regardless of stroke thicknessFixes #191.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.