Allow Symfony 5 #80
Merged
Allow Symfony 5 #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
sf5
branch
7 times, most recently
from
5e1e772 to
d42713b
Compare
Member
|
Thank you Nicolas! |
weaverryan
added a commit
that referenced
this pull request
Oct 22, 2019
This PR was merged into the master branch. Discussion ---------- Allow Symfony 5 Commits ------- 6970a17 Allow Symfony 5
B-Galati
reviewed
Nov 1, 2019
| "Symfony\\WebpackEncoreBundle\\Tests\\": "tests/" | ||
| } | ||
| }, | ||
| "minimum-stability": "dev", |
Member
Author
There was a problem hiding this comment.
Yes, it's a best practice to do this for libs.
There was a problem hiding this comment.
Thanks! I guess it's because it allows to install unstable deps easily when working on the bundle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.