Use explicit nullable type #231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
commented
Apr 19, 2024
| * @throws UndefinedBuildException if the build does not exist | ||
| */ | ||
| public function getEntrypointLookup(string $buildName = null): EntrypointLookupInterface; | ||
| public function getEntrypointLookup(?string $buildName = null): EntrypointLookupInterface; |
There was a problem hiding this comment.
@nicolas-grekas Is it a BC to add explicitly the nullable type on interfaces?
|
The CI failure is unrelated, but would you like me to integrate the coding style fix here? |
|
Fixed by #234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.