[Map] Allows Bridges JavaScript assets to be installed with npm when using file:vendor/symfony/ux-*-map/assets
#2983
+20
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n using `file:vendor/symfony/ux-*-map/assets`
Kocal
force-pushed
the
2737-no-pnpm-workspace-bis
branch
from
4689dbc to
1667af7
Compare
Kocal
commented
Aug 8, 2025
Comment on lines
-57
to
-77
| - name: Manually replacing "workspace:*" references | ||
| run: | | ||
| # npm does not support "workspace:*" references, so we need to replace them with the actual package path | ||
| for PACKAGE_DATA in $(pnpm ls -r --json --depth -1 | jq 'map(select(.private != true))' | jq -c '.[]'); do | ||
| PACKAGE=$(echo $PACKAGE_DATA | jq -r '.name') | ||
| PACKAGE_PATH=$(echo $PACKAGE_DATA | jq -r '.path') | ||
|
|
||
| echo "🔍 Searching for \"workspace:*\" references in $PACKAGE_PATH/package.json" | ||
|
|
||
| # Manually replace "workspace:" constraints with the actual package version, it ensure packages can be installed with npm | ||
| jq -rc '[(.dependencies // {}) + (.devDependencies // {}) | to_entries[] | select(.value == "workspace:*") | .key][]' "$PACKAGE_PATH/package.json" | while read -r PACKAGE_FROM_WORKSPACE ; do | ||
| echo "ℹ️ Found \"$PACKAGE_FROM_WORKSPACE\" with \"workspace:*\"" | ||
|
|
||
| PACKAGE_FROM_WORKSPACE_PATH=$(pnpm ls --filter $PACKAGE_FROM_WORKSPACE --json --depth -1 | jq -r '.[].path') | ||
| echo "ℹ️ The package \"$PACKAGE_FROM_WORKSPACE\" is located in \"$PACKAGE_FROM_WORKSPACE_PATH\" directory" | ||
|
|
||
| echo "⚒️ Replacing \"$PACKAGE_FROM_WORKSPACE\" with \"file:$PACKAGE_FROM_WORKSPACE_PATH\" in $PACKAGE_PATH/package.json" | ||
| sed -i "s|\"$PACKAGE_FROM_WORKSPACE\": \"workspace:\*\"|\"$PACKAGE_FROM_WORKSPACE\": \"file:$PACKAGE_FROM_WORKSPACE_PATH\"|g" "$PACKAGE_PATH/package.json" | ||
| done; | ||
| done | ||
|
|
There was a problem hiding this comment.
This is not needed anymore :)
This was referenced Aug 8, 2025
|
Thanks Hugo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #2982.
Moving the
"@symfony/ux-map": "workspace:*"requirements outside the package.json allows the Bridges JavaScript assets to be installed withnpmwhen@symfony/ux-leaflet-map(or@symfony/ux-google-map) is using constraint versionfile:vendor/symfony/ux-leaflet-map/assets(orfile:vendor/symfony/ux-google-map/assets) in the user application.This is possible to this super feature from pnpm: packageExtensions, which allows to override some part of package definitions in file
pnpm-workspace.yaml:@symfony/ux-mapis a dependency of@symfony/ux-leaflet-mapand@symfony/ux-google-map🎉workspace:*anymore in anypackage.json🎉It is not possible to defines
packageExtensions.devDependencies, so I usedpackageExtensions.dependenciesinstead but that's fine.@symfony/ux-mapis not referenced in anypackage.jsonwhen runningpnpm packinsrc/Bridge/*/assets.