Skip to content

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Sep 10, 2024

Q A
Bug fix? no
New feature? no
Issues Fix #2070
License MIT

Use the new Twig\DeprecatedCallableInfo added in twigphp/Twig#4291, it help us to specify the package where the alternative can be found, which was not the case before.

@Kocal Kocal force-pushed the 2070-deprecate-cva branch 4 times, most recently from fc818a7 to aef3567 Compare September 10, 2024 06:52
@Kocal Kocal marked this pull request as draft September 10, 2024 06:53
@Kocal Kocal force-pushed the 2070-deprecate-cva branch 3 times, most recently from 9584764 to 1f58821 Compare September 10, 2024 07:17
@Kocal Kocal marked this pull request as ready for review September 10, 2024 07:17
@Kocal Kocal force-pushed the 2070-deprecate-cva branch 3 times, most recently from 88c7f6a to 2271248 Compare September 10, 2024 21:22
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Let's update the src/TwigComponent/CHANGELOG too if you have time)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 10, 2024
@Kocal Kocal force-pushed the 2070-deprecate-cva branch 4 times, most recently from 2f2d76c to a872e53 Compare September 11, 2024 06:54
@Kocal Kocal force-pushed the 2070-deprecate-cva branch from a872e53 to e310074 Compare September 11, 2024 06:56
@Kocal Kocal merged commit e22484b into symfony:2.x Sep 11, 2024
42 checks passed
@Kocal Kocal deleted the 2070-deprecate-cva branch September 11, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TwigComponent] Cva in html_extra
3 participants