Skip to content

Conversation

ElectricMaxxx
Copy link
Member

@ElectricMaxxx ElectricMaxxx commented Jan 29, 2019

Let's start it here also

ToDo:

  • fix tests
  • increase phpunit version

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for keeping the dev-kit up to date. i commented on a bunch of things that i changed directly on this repo that should be ported into dev-kit rather than be reverted here.

@ElectricMaxxx
Copy link
Member Author

Btw: no problems to start with a single repository and then roll it out to the other ones, but we are tightly coupled to our testing component in dev. So we have to do them both hand in hand.

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! yeah lets drop old end-of-live symfony version.
i think we should up the minor version, as the strict types can reveal issues for users, and it will allow us to do a critical fix with symfony 2.8 support if really needed.

@ElectricMaxxx
Copy link
Member Author

@dbu can you have a look at the tests, please? Do we expose an issue by using more strict code or did i break something through my changes?

@ElectricMaxxx
Copy link
Member Author

@dbu nothing to do, my fault.

@ElectricMaxxx
Copy link
Member Author

@dbu it took some time but now it is final and green. Any hints to add on changelog? any other issues?

@ElectricMaxxx ElectricMaxxx requested a review from dbu February 28, 2019 04:19
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! i only have some change requests for the changelog, otherwise this looks excellent now!

@dbu dbu closed this Oct 22, 2020
@dbu dbu deleted the master-dev-kit branch October 22, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants