This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Improved Provider Unit Test (use Prophecy) #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
force-pushed
the
provider_test_prophecy
branch
from
67fc983 to
39782c2
Compare
dantleech
changed the title
|
👍 |
| $this->document = $this->prophesize(NodeInterface::class); | ||
| $this->item = $this->prophesize(ItemInterface::class); | ||
| $this->nodeLoader = $this->prophesize(NodeLoader::class); | ||
| $this->session = $this->prophesize(SessionInterface::class); |
There was a problem hiding this comment.
all those properties have not been defined
|
This should have been done in 2.0 imo, merge conflicts are very likely now. |
|
So we should switch to FQNs instead of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
PhpcrProviderTestCaseto use Prophecy.