Add transaction isolation. #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, |
millgi
force-pushed
the
feature/add-transaction-isolation
branch
from
5cc1a99 to
b5e131b
Compare
|
Hi Sylvain, Done, I tested it successfully at work today. |
sylvainlaurent
requested changes
Apr 25, 2018
|
|
||
| public class LogRepositoryConstants { | ||
|
|
||
| public static final String TRANSACTION_ISOLATION_COLUMN = "TRANSACTION_ISOLATION"; |
There was a problem hiding this comment.
please keep the alphabetical sorting
| final Integer transactionIsolation = (Integer) dataModel.getValueAt(modelRowIndex, columnModelIndex); | ||
| if (transactionIsolation != null ) { | ||
| switch (transactionIsolation) { | ||
| case 1: |
There was a problem hiding this comment.
please use constants in java.sql.Connection instead of numeric values
| switch (transactionIsolation) { | ||
| case 1: | ||
| component.setText("RU"); | ||
| component.setToolTipText("Read Uncommitted"); |
There was a problem hiding this comment.
I suggest to add the constant number in parentheses so that if one wants to apply a filter the value to use will be easily visible.
e.g "Read Uncommitted (1)"
|
|
||
| final StatementLog log = new StatementLog(connectionInfo.getUuid(), randomUUID(), System.currentTimeMillis(), | ||
| StatementType.BASE_NON_PREPARED_STMT, "myrawsql", Thread.currentThread().getName(), 123, true); | ||
| StatementType.BASE_NON_PREPARED_STMT, "myrawsql", Thread.currentThread().getName(), 123, true, 0); |
There was a problem hiding this comment.
0 -> java.sql.Connection.TRANSACTION_NONE
| final List<String> sqlList = Arrays.asList("st1", "st2", "st3"); | ||
| final BatchedPreparedStatementsLog batchedLogs = new BatchedPreparedStatementsLog(log.getConnectionUuid(), | ||
| randomUUID(), System.currentTimeMillis(), "myRaw stmt", sqlList, "myThread", 13, true); | ||
| randomUUID(), System.currentTimeMillis(), "myRaw stmt", sqlList, "myThread", 13, true, 1); |
millgi
force-pushed
the
feature/add-transaction-isolation
branch
from
b5e131b to
c624958
Compare
millgi
force-pushed
the
feature/add-transaction-isolation
branch
from
c624958 to
6277bd6
Compare
|
Hello Sylvain, all small fixes pushed. Sorry for the response time, other stuff to do... |
sylvainlaurent
approved these changes
May 29, 2018
|
thanks, merged to master.
Released version 0.9.0 with it
… On 29 May 2018, at 17:48, millgi ***@***.***> wrote:
Hello Sylvain, all small fixes pushed. Sorry for the response time, other stuff to do...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#69 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAr2Iqs3xLPPEU-1CEgnXNzBD4J43rERks5t3W3pgaJpZM4ThM8V>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added a column on statements showing the transaction isolation. It helped us to investigate the reason of some dead locks in our programs.