Skip to content

Conversation

myrta2302
Copy link
Contributor

@myrta2302 myrta2302 commented Oct 1, 2025

📄 Description

This PR updates the <post-popovercontainer> component by adding the following events:

  • @event() postBeforeShow: EventEmitter<{ first?: boolean }>
  • @event() postShow: EventEmitter<{ first?: boolean }>
  • @event() postHide: EventEmitter
  • @event() postBeforeToggle: EventEmitter<{ willOpen: boolean; }>
  • @event() postToggle: EventEmitter<{ isOpen: boolean; }>

making use of the new animation implementation, based on the Web Animations API.

Additionally, the <post-menu> component has been updated to:

  • Remove the use of requestAnimationFrame
  • Reduce event listeners
  • Directly consume events emitted by within the renderer (e.g. postToggle)

🚀Preview Link

https://preview-6357--swisspost-design-system-next.netlify.app/?path=/docs/8ca2bd70-56e6-4da9-b1fd-4e55388dca88--docs

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

hugomslv and others added 30 commits May 30, 2025 10:26
…b-animations-api' of https://github.com/swisspost/design-system into 5463-refactor-post-popovercontainer-animation-to-use-web-animations-api
…-trigger-and-post-menu-items-when-nvda-is-running
…d-post-menu-items-when-nvda-is-running' of https://github.com/swisspost/design-system into 5837-bug-accessibility-issues-with-post-menu-trigger-and-post-menu-items-when-nvda-is-running
…-trigger-and-post-menu-items-when-nvda-is-running
@myrta2302 myrta2302 marked this pull request as ready for review October 2, 2025 07:54
@myrta2302 myrta2302 requested a review from a team as a code owner October 2, 2025 07:54
@myrta2302 myrta2302 requested review from alizedebray and leagrdv and removed request for a team and leagrdv October 2, 2025 07:54
@myrta2302 myrta2302 changed the title chore(components): update <post-menu> and `<post-popovecontainer> to enforce separation of concerns chore(components): update <post-menu> and <post-popovecontainer> to enforce separation of concerns Oct 2, 2025
@alizedebray alizedebray requested review from alizedebray and removed request for alizedebray October 3, 2025 06:36
Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remove myself from the reviewer until both dependencies are merged (#6042 & #5586).

@myrta2302 myrta2302 added the 🚂 PR train PR which follows another one. label Oct 3, 2025
Base automatically changed from 5837-bug-accessibility-issues-with-post-menu-trigger-and-post-menu-items-when-nvda-is-running to main October 3, 2025 12:26
@myrta2302 myrta2302 removed the 🚂 PR train PR which follows another one. label Oct 6, 2025
@myrta2302 myrta2302 requested a review from alizedebray October 6, 2025 09:35
@myrta2302 myrta2302 requested a review from alizedebray October 20, 2025 09:09
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update <post-menu> and <post-popovecontainer> to enforce separation of concerns

4 participants