-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[IDE] Add full documentation to code completion result #82464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[IDE] Add full documentation to code completion result #82464
Conversation
314f83c
to
b70fcc7
Compare
@rintaro @hamishknight I've reverted changes to SourceKit tests (except for invalid redeclaration fixes) and added some tests under |
@swift-ci Please test |
Some tests are failing due to failures in USR to Decl verification. I suspect this is the same issue we had with extension binding causing the creation of an incomplete I'm looking into it. |
…less extension The USR for declarations within the extension with no type name have a USR that looks like a top-level declaration causing the lookup within swift::Demangle::getDeclForUSR to fail.
Failing tests can be categorized into 3 buckets:
|
validation-test/IDE/crashers_fixed/006-swift-declcontext-getprotocolself.swift
Outdated
Show resolved
Hide resolved
validation-test/IDE/crashers_fixed/064-swift-genericfunctiontype-get.swift
Outdated
Show resolved
Hide resolved
df0a177
to
fe26400
Compare
@swift-ci please test |
@hamishknight It's going to fail again since we've neither addressed nor muted the issues in tests that import Cocoa, I think we can cancel it until we decide on whether we're going to put time into fixing this or if we're gonna skip it for now. wdyt? |
I know, I just wanted to run the tests on the operator name change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
5adc3b4
to
6b75749
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me double check with the Clang Importer folks that they're happy with the compatibility alias change, but this LGTM thank you!
@hamishknight macOS and Linux tests don't seem to be running, any idea why this is happening? |
Weird, let's try again @swift-ci please test |
@hamishknight They're failing now. There seems to be an issue in the shell script it's trying to run (an unmatched single quote).
|
@swift-ci please test |
…complete_where_clause
6b75749
to
380b304
Compare
I've rebased the PR on One more side change: I added a @hamishknight @rintaro Can you please re-review and run the tests? 🙏🏼 |
Retrieve and return full documentation in code completion results and expose it in:
swiftide_completion_item_get_doc_full
sourcekitd-test
though not used in SourceKit LSP) in thekey.doc.full_as_xml
key.This PR depends on #82887.