[IRGen] Return typed errors directly in synchronous functions when po… #74192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This definitely needs some cleanups and code deduplication, but ready for first review pass. |
drexin
commented
Jun 6, 2024
| @@ -338,6 +347,22 @@ void IRGenThunk::emit() { | |||
|
|
|||
| emission->end(); | |||
|
|
|||
| // FIXME: we shouldn't have to generate all of this. We should just forward | |||
| // the value as is | |||
| if (auto &error = emission->getTypedErrorExplosion()) { | |||
There was a problem hiding this comment.
This is temporary. This should really be a tail call.
|
Please test with following pull request: @swift-ci smoke test |
drexin
force-pushed
the
wip-typed-throws-abi
branch
from
4aba6ae to
99b0e83
Compare
|
Please test with following pull request: @swift-ci smoke test |
…ssible rdar://129359355 This PR implements the basic support for returning typed errors directly and applies it to synchronous functions.
drexin
force-pushed
the
wip-typed-throws-abi
branch
from
99b0e83 to
d9bc2cb
Compare
|
Please test with following pull request: @swift-ci smoke test |
|
Please test with following pull request: @swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssible
rdar://129359355
This PR implements the basic support for returning typed errors directly and applies it to synchronous functions.