[stdlib] Review & update hash testing to use Hasher's new features #16066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to understand failure traces in test logs.
This is safe to do with hash(into:), because random hash collisions can be eliminated with awesome certainty by trying a number of different hash seeds. (Unless there is a weakness in SipHash.) In some cases, we intentionally want hashing to produce looser equivalency classes than equality — to let those cases keep working, add an optional hashEqualityOracle parameter. Review usages of checkHashable and add hash oracles as needed.
This prototype is not fully implemented, and it relies on specific hash values to not trigger unhandled cases. To keep its test working, define and use a custom hashing interface that emulates hashValue behavior prior to SE-0206.
lorentey
force-pushed
the
better-hash-tests
branch
from
645aa56 to
6984782
Compare
Member
Author
|
@swift-ci please test |
This was referenced Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkHashableto verify that different values hash differently -- we can do this withhash(into:)because we can eliminate hash collisions by trying different seeds.MinimalHashable*types to use_hash(into:)as the primary hashing interface.