Skip to content

Simplify statically-linked section discovery. #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2025
Merged

Simplify statically-linked section discovery. #940

merged 1 commit into from
Feb 5, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Feb 4, 2025 •
edited
Loading

This PR simplifies the code used to discover metadata sections when the testing library is statically linked into a test target.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Simplify statically-linked section discovery.
bdb818b 
This PR simplifies the code used to discover metadata sections when the testing
library is statically linked into a test target.
@grynspan grynspan added the less-c++ 🐀 Work to reduce the size of our C++ codebase and/or dependencies label Feb 4, 2025
@grynspan grynspan added this to the Swift 6.x milestone Feb 4, 2025
@grynspan grynspan self-assigned this Feb 4, 2025
@grynspan
Copy link
Contributor Author

grynspan commented Feb 4, 2025

@swift-ci test

stmontgomery
stmontgomery reviewed Feb 5, 2025
View reviewed changes
@grynspan grynspan merged commit 57335d7 into main Feb 5, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/smoller-static-discovery branch February 5, 2025 21:14
@grynspan grynspan added the discovery 🔎 test content discovery label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels

discovery 🔎 test content discovery less-c++ 🐀 Work to reduce the size of our C++ codebase and/or dependencies

Projects

None yet

Milestone

Swift 6.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@grynspan @stmontgomery