Ensure the ObjectiveC module is visible to Discovery.swift
#933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With recent work to rewrite our C++ code in Swift, we've wound up not including any Objective-C headers in `_TestingInternals`, but they are included transitively on some Apple platforms including macOS. Ensure the `ObjectiveC` module is included in Discovery.swift when available so that platforms that don't transitively include the libobjc headers can see (in particular) the `objc_addLoadImageFunc()` function.
grynspan
added
bug
grynspan
requested review from
SeanROlszewski,
briancroom,
stmontgomery and
suzannaratcliff
as code owners
|
@swift-ci test |
stmontgomery
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent work to rewrite our C++ code in Swift, we've wound up not including any Objective-C headers in
_TestingInternals, but they are included transitively on some Apple platforms including macOS. Ensure theObjectiveCmodule is included in Discovery.swift when available so that platforms that don't transitively include the libobjc headers can see (in particular) theobjc_addLoadImageFunc()function.Checklist: