Skip to content

Remove arm64e ptrauth resigning from test content discovery. #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2025
Merged

Remove arm64e ptrauth resigning from test content discovery. #919

merged 2 commits into from
Jan 21, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Jan 17, 2025 •
edited
Loading

Finally got around to double-checking and we don't need to do ptrauth resigning on the accessor function pointers in the new test content section as dyld already does it for us at load time.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Remove arm64e ptrauth resigning from test content discovery.
ac4c39a 
Finally got around to double-checking and we don't need to do ptrauth resigning
on the `accessor` function pointers in the new test content section as dyld
already does it for us at load time.
@grynspan grynspan added bug 🪲 Something isn't working darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support labels Jan 17, 2025
@grynspan grynspan added this to the Swift 6.x milestone Jan 17, 2025
@grynspan grynspan self-assigned this Jan 17, 2025
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test Windows

@grynspan grynspan added the less-c++ 🐀 Work to reduce the size of our C++ codebase and/or dependencies label Jan 19, 2025
@grynspan
Copy link
Contributor Author

@swift-ci test Windows

@grynspan grynspan merged commit 1747fb0 into main Jan 21, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/no-ptrauth-needed branch January 21, 2025 19:22
@grynspan grynspan added the discovery 🔎 test content discovery label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom briancroom approved these changes

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels

bug 🪲 Something isn't working darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support discovery 🔎 test content discovery less-c++ 🐀 Work to reduce the size of our C++ codebase and/or dependencies

Projects

None yet

Milestone

Swift 6.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@grynspan @stmontgomery @briancroom