Skip to content

Work around swiftinterface generation bug on Windows. #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Work around swiftinterface generation bug on Windows. #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bd849c
Work around swiftinterface generation bug on Windows.
grynspan Sep 5, 2024
978259e
Fix test
grynspan Sep 5, 2024
ef29651
Reorder attributes
grynspan Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Sources/Testing/Issues/Issue+Recording.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,12 @@ extension Issue {
// MARK: - Debugging failures

/// A unique value used by ``failureBreakpoint()``.
@usableFromInline @exclusivity(unchecked) nonisolated(unsafe) var failureBreakpointValue = 0
#if !os(Windows)
// Work around compiler bug by not specifying unchecked exclusivity on Windows.
// SEE: https://github.com/swiftlang/swift/issues/76279
@exclusivity(unchecked)
#endif
@usableFromInline nonisolated(unsafe) var failureBreakpointValue = 0

/// A function called by the testing library when a failure occurs.
///
Expand Down Expand Up @@ -272,5 +277,5 @@ func failureBreakpoint() {
// opportunities elsewhere. Instead, this function performs a trivial
// operation on a usable-from-inline value, which the compiler must assume
// cannot be optimized away.
failureBreakpointValue = 1
failureBreakpointValue = 0
}
4 changes: 2 additions & 2 deletions Tests/TestingTests/MiscellaneousTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,9 +531,9 @@ struct MiscellaneousTests {

@Test("failureBreakpoint() call")
func failureBreakpointCall() {
failureBreakpointValue = 0
failureBreakpointValue = 1
failureBreakpoint()
#expect(failureBreakpointValue == 1)
#expect(failureBreakpointValue == 0)
}

@available(_clockAPI, *)
Expand Down