Block signal masks pre-fork and restore post-fork. #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
parkera
reviewed
Apr 29, 2025
|
Instead of a monolithic |
|
@swift-ci please test |
iCharlesHu
force-pushed
the
charles/fork-exec-signals
branch
from
75505ba to
a56ee26
Compare
parkera
approved these changes
Apr 30, 2025
On Darwin and Linux, rearchitect `TrackedFileDescriptor` (now named `DiskIO`) to either hold a `FileDescriptor` or a `DispatchIO`. We create `DispatchIO` as the last step of `spawn()` and use it to perform read/write, as well as cleanup instead of using a raw file descriptor.
iCharlesHu
force-pushed
the
charles/fork-exec-signals
branch
from
a56ee26 to
1a91649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces proper signal blocking and restoring for custom
fork/execon Linux.Resolves: iCharlesHu/Subprocess#45
Resolves: iCharlesHu/Subprocess#46
—
During testing, one of the newly added tests revealed that we were not managing
DispatchIOcorrectly during early terminations on Darwin and Linux. Currently, we simply close the file descriptors in the clean-up handler, which is incorrect becauseDispatchIOis used for read/write operations on these file descriptors. Modifying the file descriptor after it has been “transferred” toDispatchIOis considered a programmer error.Rearchitect
TrackedFileDescriptor(now renamedDiskIO) to either hold aFileDescriptoror aDispatchIO. We createDispatchIOas the final step ofspawn()and use it for read/write operations and cleanup, instead of using a raw file descriptor. This allowsDispatchIOto naturally close the file descriptor itself.