[6.0] Adding some more tests for [U]Int128 in BinaryInteger+FormatStyleTests.swift and JSONEncoderTests.swift #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

lamtrinhdev wants to merge 1 commit into swiftlang:release/6.0 from lamtrinhdev:Add_more_test_Int128_Swift6

Contributor

lamtrinhdev commented Aug 2, 2024

Clone of #806 for 6.0

Summary:

Add some more testTypeCoercion in testTypeCoercion()
Add some more check [U]Int128 in testNumericStringRepresentation_builtinIntegersLimits()
Correct typo comment from resovled to resolved at URL.swift

Modifications:

Sources/FoundationEssentials/URL/URL.swift
Tests/FoundationEssentialsTests/Formatting/BinaryInteger+FormatStyleTests.swift
Tests/FoundationEssentialsTests/JSONEncoderTests.swift

Reviewers: @parkera , @stephentyrone


          Add more test for [U]Int128 and fix typo comment.

Contributor Author

lamtrinhdev commented Aug 6, 2024

Dear @parkera , @stephentyrone ,

Could you please help me to review the PR?

Thanks,
Lam

Contributor

stephentyrone commented Aug 6, 2024

This is not needed for 6.0.

stephentyrone closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet