Fix infinite loop when force casting NSError to CocoaError #5115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnabeyang
force-pushed
the
fix-core_error-cast-infinit-loop
branch
from
0b3b469 to
8a3d11e
Compare
|
@swift-ci test |
|
Thanks for this fix. We are strangely inconsistent about which bridging function is 'primary' for these types; sometimes it funnels to conditionally, sometimes unconditionally, sometimes none of the above. |
parkera
approved these changes
Oct 18, 2024
parkera
pushed a commit
to parkera/swift-corelibs-foundation
that referenced
this pull request
Oct 18, 2024
…swiftlang#5115) (cherry picked from commit bf7369a)
parkera
added a commit
that referenced
this pull request
Oct 22, 2024
…#5115) (#5116) (cherry picked from commit bf7369a) Co-authored-by: noriaki watanabe <[email protected]>
parkera
pushed a commit
to parkera/swift-corelibs-foundation
that referenced
this pull request
Oct 22, 2024
…swiftlang#5115) (cherry picked from commit bf7369a)
parkera
added a commit
that referenced
this pull request
Oct 22, 2024
…#5115) (#5119) (cherry picked from commit bf7369a) Co-authored-by: noriaki watanabe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an infinite loop issue that occurred when force casting
NSErrortoCocoaError. The problem arose because_forceBridgeFromObjectiveCwas calling_unconditionallyBridgeFromObjectiveC, and in turn,_unconditionallyBridgeFromObjectiveCwas calling_forceBridgeFromObjectiveC, causing a recursive loop.