Skip to content

Fix bounds checking error when parsing WWW-Authenticate field #5103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix bounds checking error when parsing WWW-Authenticate field #5103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e73543
add TestURLProtectionSpace.test_createWithInvalidAuth to test parsing…
toffaletti Oct 11, 2024
c670a75
add bounds checking to rangeOfTokenPrefix. Fixes Fatal error: Substri…
toffaletti Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/FoundationNetworking/URLSession/HTTP/HTTPMessage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ private extension String.UnicodeScalarView.SubSequence {
var rangeOfTokenPrefix: Range<Index>? {
guard !isEmpty else { return nil }
var end = startIndex
while self[end].isValidMessageToken {
while end != self.endIndex && self[end].isValidMessageToken {
end = self.index(after: end)
}
guard end != startIndex else { return nil }
Expand Down
17 changes: 17 additions & 0 deletions Tests/Foundation/TestURLProtectionSpace.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,5 +203,22 @@ class TestURLProtectionSpace : XCTestCase {
XCTAssertEqual(param8_2_2.name, "param")
XCTAssertEqual(param8_2_2.value, "")
}

func test_createWithInvalidAuth() throws {
let headerFields1 = [
"Server": "Microsoft-IIS/10.0",
"request-id": "c71c2202-4013-4d64-9319-d40aba6bbe5c",
"WWW-Authenticate": "fdsfds",
"X-Powered-By": "ASP.NET",
"X-FEServer": "AM6PR0502CA0062",
"Date": "Sat, 04 Apr 2020 16:19:39 GMT",
"Content-Length": "0",
]
let response1 = try XCTUnwrap(HTTPURLResponse(url: URL(string: "https://outlook.office365.com/Microsoft-Server-ActiveSync")!,
statusCode: 401,
httpVersion: "HTTP/1.1",
headerFields: headerFields1))
XCTAssertNil(URLProtectionSpace.create(with: response1))
}
#endif
}