Move DocumentationLanguageService to a separate module #2242
+60
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please test |
matthewbastien
approved these changes
Aug 14, 2025
bnbarham
approved these changes
Aug 14, 2025
| @@ -15,6 +15,10 @@ import LanguageServerProtocol | |||
| package import SourceKitLSP | |||
| import SwiftLanguageService | |||
|
|
|||
| #if canImport(DocumentationLanguageService) | |||
There was a problem hiding this comment.
Do we not need to guard the DocumentationLanguageService use down below?
There was a problem hiding this comment.
We do. Apparently I also added the check in a future commit that just didn’t make it into this PR 😂
ahoppen
force-pushed
the
move-docc-service
branch
from
5f209ae to
fc80a66
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
move-docc-service
branch
from
fc80a66 to
de02f60
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
move-docc-service
branch
from
de02f60 to
aeffb2e
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the effort started in #2228.