Extend availability attribute to support feature-based availability #10180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the `__availability` attribute to accept a feature
name and a boolean-like integer argument (0 or 1) to indicate
availability based on feature presence or absence.
`__builtin_available` and `@available` take a feature name as their
arguments. References to annotated declarations in unguarded contexts
are rejected.
For example:
```
__attribute__((availability(domain:feature1, 0)))
void available_func(void);
__attribute__((availability(domain:feature1, 1)))
void unavailable_func(void);
if (__builtin_available(feature1)) {
available_func();
unavailable_func(); // error
} else {
available_func(); // error
unavailable_func();
}
```
rdar://137999979
rdar://146057514
Set it in ActOnObjCAvailabilityCheckExpr instead. Without this change, DiagnoseUnguardedFeatureAvailability scans the whole function when there is a label in it even when there are no Decls annotated with feature availability that are referenced in the function and there are no ObjCAvailabilityCheckExprs. rdar://146139827
passing it to diagnoseDeclFeatureAvailability rdar://146139827
|
@swift-ci please test llvm |
|
@swift-ci please test |
|
@ahatanaka It appears this caused a windows CI failure: swiftlang/swift#79819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends the
__availabilityattribute to accept a feature name and a boolean-like integer argument (0 or 1) to indicate availability based on feature presence or absence.__builtin_availableand@availabletake a feature name as their arguments. References to annotated declarations in unguarded contexts are rejected.For example:
rdar://137999979