feat(es/parser): Add disallowAssertKeywords option

[petamoriken]

Description:

V8 will remove support for the assert keywords, so Node.js and Chrome will follow suit.

Hey, quick update on this. Node.js is planning to remove support for assert in v22 (which will be released in April) and Chrome in v126 (which will be released in May).

denoland/deno#17944 (comment)

Disallow the assert keywords in Deno by adding the disallowAssertKeywords option in this PR.

BREAKING CHANGE:

N/A

Related issue (if exists):

#8893 (comment)

[changeset-bot]

⚠️ No Changeset found

Latest commit: af8d6f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[petamoriken]

@kdy1 Where should I write the test codes?

[kdy1]

You can add a test like

swc/crates/swc_ecma_parser/src/parser/tests.rs

Lines 321 to 345 in c1115a2

	#[test]
	fn illegal_language_mode_directive2() {
	test_parser(
	r#"let f = (a = 0) => { "use strict"; }"#,
	Default::default(),
	|p| {
	let program = p.parse_program()?;
	let errors = p.take_errors();
	assert_eq!(
	errors,
	vec![Error::new(
	Span {
	lo: BytePos(22),
	hi: BytePos(35),
	ctxt: swc_common::SyntaxContext::empty()
	},
	crate::parser::SyntaxError::IllegalLanguageModeDirective
	)]
	);
	Ok(program)
	},
	);
	}

[kdy1]

swc-bump:

• swc_ecma_parser --breaking

[kdy1]

Please remove this

[kdy1]

We should unconditionally follow the behavior of tsc

[petamoriken]

Oh, I see. The issue I want to solve with this PR is that it prevents the assert keywords from being used in TypeScript, so I'll try to confirm if tsc can handle it.

[kdy1]

and this

[petamoriken]

Since tsc has not decided on a direction, this pull request is closed for the time being.