Skip to content

Add extension to keep track of original swagger version #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 4, 2020
Merged

Add extension to keep track of original swagger version #1374

merged 4 commits into from
Jul 4, 2020

Conversation

@sebastien-rosset
Copy link
Contributor

@sebastien-rosset sebastien-rosset commented May 15, 2020 •
edited
Loading

This is a proposed change to retain the original value of the "swagger" keyword when converting a OAS/Swagger 2.0 document to a 3.0 OAS document.

@sebastien-rosset sebastien-rosset marked this pull request as ready for review May 15, 2020 23:48
@sebastien-rosset sebastien-rosset mentioned this pull request May 20, 2020
Merged
5 tasks
@frantuma frantuma added this to the M2 milestone May 23, 2020
@frantuma frantuma modified the milestones: M2, M3 Jun 2, 2020
@frantuma frantuma modified the milestones: M3, M4 Jun 17, 2020
@gracekarina
Copy link
Contributor

gracekarina commented Jul 4, 2020

Hi @sebastien-rosset can you please update the branch so we can merge? thanks!

@sebastien-rosset
Copy link
Contributor Author

sebastien-rosset commented Jul 4, 2020

Hi @sebastien-rosset can you please update the branch so we can merge? thanks!

Done. Just a thought, how about renaming the extension to x-original-openapi-version? In the future, there may be a similar use case when version 3 is converted to version 4, so it makes more sense to use openapi instead of swagger

@gracekarina gracekarina merged commit 991b5f8 into swagger-api:master Jul 4, 2020
@codymikol codymikol mentioned this pull request Oct 4, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gracekarina gracekarina

Labels

None yet

Projects

None yet

Milestone

M4

Development

Successfully merging this pull request may close these issues.

3 participants

@sebastien-rosset @gracekarina @frantuma