Skip to content

[JavaScript] Handle custom request.agent #6737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2017
Merged

[JavaScript] Handle custom request.agent #6737

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3e1d13
Handle custom request.agent
kinok Oct 18, 2017
ff8fd32
better semantic
kinok Oct 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions modules/swagger-codegen/src/main/resources/Javascript/ApiClient.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@
this.agent = new superagent.agent();
}

/*
* Allow user to override superagent agent
*/
this.requestAgent = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use null instead of false for better semantics.

};

{{#emitJSDoc}} /**
Expand Down Expand Up @@ -408,6 +412,12 @@
// set header parameters
request.set(this.defaultHeaders).set(this.normalizeParams(headerParams));


// set requestAgent if it is set by user
if (this.requestAgent) {
request.agent(this.requestAgent);
}

// set request timeout
request.timeout(this.timeout);

Expand Down
11 changes: 11 additions & 0 deletions modules/swagger-codegen/src/main/resources/Javascript/es6/ApiClient.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ export default class ApiClient {
if (typeof window === 'undefined') {
this.agent = new superagent.agent();
}

/*
* Allow user to override superagent agent
*/
this.requestAgent = false;

}

{{#emitJSDoc}}/**
Expand Down Expand Up @@ -396,6 +402,11 @@ export default class ApiClient {
// set header parameters
request.set(this.defaultHeaders).set(this.normalizeParams(headerParams));

// set requestAgent if it is set by user
if (this.requestAgent) {
request.agent(this.requestAgent);
}

// set request timeout
request.timeout(this.timeout);

Expand Down