isssue#2579: added "UserAgent" in configuration #2593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ApiKey: make(map[string]string), | ||
| ApiKeyPrefix: make(map[string]string) , | ||
| ApiKeyPrefix: make(map[string]string), | ||
| UserAgent: "{{#httpUserAgent}}{{{.}}}{{/httpUserAgent}}{{^httpUserAgent}}Swagger-Codegen/{{{version}}}/go{{/httpUserAgent}}", |
There was a problem hiding this comment.
@guohuang I think {{version}} (the API spec version) should be replaced by {{packageVersion}} (SDK version)
There was a problem hiding this comment.
it is inconsistent, in php, it uses {artifactVersion}}, anyway, the code has been updated, it worked.
There was a problem hiding this comment.
Yes, different languages have different CLI name for option. For perl, it's moduleVersion. For Ruby, it's gemVersion.
I did it that way because Perl developers would have no idea what artifactVersion is and moduleVersion should be more familiar to them, and similarly for other languages.
|
@guohuang thanks for the contribution as always. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2579 @wing328 I added "UserAgent" to config struct, i tried running the CLI with
--http-user-agentit replaced the default value as expected.