Skip to content

[Feign]Fix wrong query param key name in feign client #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2016
Merged

[Feign]Fix wrong query param key name in feign client #1874

merged 1 commit into from
Jan 12, 2016

Conversation

@cbornet
Copy link
Contributor

@cbornet cbornet commented Jan 11, 2016

Query params get generated as

@RequestLine("GET /myendpoint?myId={myId}")

instead of

@RequestLine("GET /myendpoint?my_id={myId}")

when the query param name is "my_id"

@cbornet cbornet changed the title Fix wrong query param key name in feign client [Feign]Fix wrong query param key name in feign client Jan 11, 2016
@wing328 wing328 added this to the v2.1.6 milestone Jan 12, 2016
@wing328
Copy link
Contributor

wing328 commented Jan 12, 2016

@cbornet thanks for the fix.

wing328 added a commit that referenced this pull request Jan 12, 2016
@wing328
Merge pull request #1874 from cbornet/fix_param
ece56af 
[Feign]Fix wrong query param key name in feign client
@wing328 wing328 merged commit ece56af into swagger-api:master Jan 12, 2016
@cbornet cbornet deleted the fix_param branch June 29, 2016 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Client: Java Issue: Bug

Projects

None yet

Milestone

v2.1.6

Development

Successfully merging this pull request may close these issues.

2 participants

@cbornet @wing328