chore(docs): typo fix in docker md #12591
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @frankkilcommins, thanks for pointing that out, addressed in #12595 |
|
@djankows no probs. It's a little strange that you created a new PR instead of merging this one? No big issue for me, but if we get PRs from the community we need to ensure we attribute those appropriately rather than re hashing in new PRs. |
|
Hi @frankkilcommins, @djankows created new PR because at the moment you created PR we had issue with github secrets and PR builds were failing. Once we fixed it unfortunately we couldn't run builds for PRs created in meantime - that's why for this issue it was much faster to create new PR. Currently everything is straighten up and finally we were able to merge one affected community PR without creating new one on our side. ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.