Skip to content

Conversation

Rich-Harris
Copy link
Member

I forgot to account for CSP when adding inline styles for bundleStrategy: 'inline'.

No test in this PR because there are no tests for bundleStrategy: 'inline' anyway, and life is too short to worry about such things during the Christmas break

Also, hashes were being printed twice, inexplicably (if harmlessly) — this fixes that


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: bfe44b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

preview: https://svelte-dev-git-preview-kit-13232-svelte.vercel.app/

this is an automated message

@teemingc teemingc merged commit 12ce7eb into main Dec 24, 2024
14 checks passed
@teemingc teemingc deleted the inline-bundle-csp branch December 24, 2024 05:53
This was referenced Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants