Skip to content

Conversation

@namsnath
Copy link
Contributor

@namsnath namsnath commented Apr 16, 2025

Summary of change

  • Ensures that verified TOTP devices can only be removed after MFA requirements are completed
  • Removes override for global claim validators

Related issues

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

- Ensures that verified TOTP devices can only be removed after MFA requirements are completed
- Removes override for global claim validators
@namsnath namsnath self-assigned this Apr 16, 2025
@namsnath namsnath requested a review from sattvikc April 16, 2025 08:36
@promptless
Copy link

promptless bot commented Apr 16, 2025

✅ No documentation updates required.

@sattvikc sattvikc merged commit 08a3d29 into 0.29 Apr 16, 2025
11 checks passed
@sattvikc sattvikc deleted the fix/removeDevice-claim-check branch April 16, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants