feat: uses containerised core in unit tests #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namsnath
changed the title
porcellus
reviewed
Feb 26, 2025
namsnath
force-pushed
the
ci/github-actions/containerized-core/unit-tests
branch
from
3684f9b to
5d00d6d
Compare
porcellus
requested changes
Mar 4, 2025
porcellus
approved these changes
Mar 5, 2025
namsnath
force-pushed
the
ci/github-actions/containerized-core/unit-tests
branch
from
d642354 to
7fd939b
Compare
- Adds unit test workflow
- Test changes:
- Removes all instances of start_st, clean_st, setup_st, setup_function, teardown_function
- Adds per-test setup/teardown to call `reset()`
- Replaces `start_st` calls and usages of `localhost:3567` with `get_new_core_app_url` equivalents
- Creates a new application in the core
- Removes unused constants and functions
- Adds TODOs for test cleanup
- Removes `st_common_init_args` constant, prefers use of `get_st_init_args` instead
- Adds actions for common tasks
- https://github.com/supertokens/get-versions-action
- https://github.com/supertokens/get-supported-versions-action
- Updates unit test Circle CI scripts
namsnath
force-pushed
the
ci/github-actions/containerized-core/unit-tests
branch
from
7fd939b to
6651f79
Compare
namsnath
added a commit
that referenced
this pull request
Mar 6, 2025
- Changes `test-unit` command to ensure `Makefile` is found
- Reverts use of `get_new_core_url` in `test-server`
- Introduced in #561
sattvikc
pushed a commit
that referenced
this pull request
Mar 6, 2025
- Changes `test-unit` command to ensure `Makefile` is found
- Reverts use of `get_new_core_url` in `test-server`
- Introduced in #561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
reset()start_stcalls and usages oflocalhost:3567withget_new_core_app_urlequivalentsst_common_init_argsconstant, prefers use ofget_st_init_argsinsteadRelated issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens_python/constants.pyfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)setup.pysupertokens_python/constants.pygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.supertokens_python/utils.pyfile to include that in theFRAMEWORKSvariablesyncio/asynciofunctions are consistent.tests/sessions/test_access_token_version.pyto account for any new claims that are optional or omitted by the coreRemaining TODOs for this PR
requiredchecks OR change settings to allow merge after all checks successful