Skip to content

Conversation

@namsnath
Copy link
Contributor

@namsnath namsnath commented Feb 6, 2025

Summary of change

  • BitBucket
    • Cleans up primary email logic
    • Moves email key from from_id_token_payload to from_user_info_api in raw_user_info_from_provider
      • Consistent with Node SDK outputs
  • Github
    • Changes id field access to be concrete to be in-line with API Spec
    • Adds raw user info to output
    • Makes primary email logic consistent with BitBucket
  • LinkedIn
    • Changes sub field access to be concrete to be in-line with API Spec
    • Adds raw user info to output

Related issues

Test Plan

  • Test login using BitBucket/Github/Linkedin, verify raw user data present in UserInfo.
    • Tested locally for Bitbucket and Github.

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

@namsnath namsnath self-assigned this Feb 6, 2025
@namsnath namsnath requested a review from sattvikc February 7, 2025 13:39
- BitBucket
  - Cleans up primary email logic
  - Moves `email` key from `from_id_token_payload` to `from_user_info_api` in `raw_user_info_from_provider`
- Github
  - Changes `id` field access to be concrete to be in-line with API Spec
  - Adds raw user info to output
  - Makes primary email logic consistent with BitBucket
- LinkedIn
  - Changes `sub` field access to be concrete to be in-line with API Spec
  - Adds raw user info to output

Co-authored-by: Viraj Kanwade <[email protected]>
@namsnath namsnath changed the base branch from master to 0.28 February 7, 2025 13:42
@sattvikc sattvikc merged commit 968c756 into supertokens:0.28 Feb 11, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants