Skip to content

Conversation

@coolbueb
Copy link
Contributor

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.
  • If added a new entry point, then make sure that it is importable by adding it to the exports in package.json

Remaining TODOs for this PR

  • Item1
  • Item2

@netlify
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for astounding-pegasus-21c111 canceled.

Name Link
🔨 Latest commit 7432b74
🔍 Latest deploy log https://app.netlify.com/sites/astounding-pegasus-21c111/deploys/67d8d4c882ad8a00087e5057

@netlify
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for precious-marshmallow-968a81 canceled.

Name Link
🔨 Latest commit 7432b74
🔍 Latest deploy log https://app.netlify.com/sites/precious-marshmallow-968a81/deploys/67d8d4c885f138000891dd4d

@porcellus porcellus changed the base branch from master to 22.0 March 18, 2025 02:06
@porcellus porcellus marked this pull request as ready for review March 18, 2025 02:07
@porcellus porcellus merged commit 0b4ce1a into 22.0 Mar 18, 2025
15 of 30 checks passed
@porcellus porcellus deleted the feat/webauthn/base branch March 18, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants