Skip to content

feat(auth): add MFA phone #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2024
Merged

feat(auth): add MFA phone #496

merged 1 commit into from
Aug 12, 2024

Conversation

@grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Aug 10, 2024

What kind of change does this PR introduce?

Adds support for MFA with Phone factor

  • Enroll - now allows for enrollment of Phone Factors
  • Challenge for Phone - now takes in a channel
  • List Factors - now supports access of Phone factors

Additional context

JS: supabase/auth-js#932

@grdsdev grdsdev requested review from J0 and dshukertjr August 10, 2024 20:39
J0
J0 approved these changes Aug 12, 2024
View reviewed changes
Copy link

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@grdsdev grdsdev merged commit 2e445f2 into main Aug 12, 2024
@grdsdev grdsdev deleted the feat/mfa-phone branch August 12, 2024 14:47
@github-actions github-actions bot mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dshukertjr dshukertjr Awaiting requested review from dshukertjr

1 more reviewer

@J0 J0 J0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grdsdev @J0