chore: improved storage errors #752
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Support gets a lot of requests for help around bucket vs global file size limits. For example:
supabase/supabase#38272 introduces UI clarity for Studio users. This PR introduces clarity at this error-message level, for API users.
What is the current behavior?
A user who forgets they have a bucket limit set will get a vague error message like:
That isn’t very helpful, especially with the potential footguns of global and bucket-specific limits.
What is the new behavior?
Clearer error message with bucket and/or global file size limits inline. For example, using that same scenario above:
It also makes the global-only situation a bit clearer:
And if no context is provided:
Additional context and outstanding questions
context?: { bucketName?: string; bucketLimit?: number; globalLimit?: number })
bucketName
,bucketLimit
, andglobalLimit
to API users? Or do we need to check the user’s permissions per project?