This repository was archived by the owner on Sep 8, 2025. It is now read-only.
fix: pass params as query params for get/head requests #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekg999
changed the title
Pull Request Test Coverage Report for Build 14993454641Details
💛 - Coveralls |
|
Hi @abhishekg999 thank you for this fix. Can you also add a test for asserting the behavior? Thanks. |
|
@grdsdev TY, also noticed BaseRPCRequestBuilder also doesnt merge the prefer header. I made an update to that to match the behavior in postgrest-js. |
grdsdev
reviewed
May 13, 2025
postgrest/base_request_builder.py
Outdated
| @@ -660,7 +660,11 @@ def select( | |||
| """ | |||
| method, params, headers, json = pre_select(*columns, count=None) | |||
| self.params = self.params.add("select", params.get("select")) | |||
| self.headers["Prefer"] = "return=representation" | |||
| if self.headers.get("prefer"): | |||
There was a problem hiding this comment.
Is headers in python case-insensitive? This line is checking for prefer, and the line below for Prefer.
There was a problem hiding this comment.
Actually it should both normalize to lowercase,I just did that to match the get("select") in the line above, but I like keeping it uppercase
There was a problem hiding this comment.
It is case-insensitive*
grdsdev
approved these changes
May 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Allows using GET and HEAD methods on Postgrest RPC functions with arguments.
What is the current behavior?
RPC functions always try to send params in the body. This will fail for GET and HEAD methods.
Please link any relevant issues here.
#592
What is the new behavior?
You can now properly use get=True / head=True in postgrest RPC func calls.