Rename from and fix rpc builder
#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug with the RPC builder setting the query builder's method to the RPC's schema. Added a test for RPC functions. Removed unnecessary testing framework. Updated README.md
RPC builder was passing `schema` to the `method` property.
|
would be great to merge this to make rpc work |
grdsdev
approved these changes
Aug 18, 2021
|
Any chance this PR could be merged? Need the RPC builder to be fixed and it's been nearly 2 weeks and has been reviewed. |
|
I think only @satishbabariya has write access to this, can you review and merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
PostgrestClient.form()toPostgrestClient.from()to be the same as the other Supabase client librariesPostgrestRpcBuilderwhere themethodvalue was being given theschemaparameter when creating thePostgrestTransformBuilderThis does introduce a breaking change
Changing
formtofromwill cause an error to be thrown when compiling after updating the library. One fix would be to keep the original name alongside the new one but provide a depreciation warning. However the library is in alpha stage so that might be unnecessary.