Add support for Jira Issue Properties #474
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add .dup when defaulting the 'value' from properties internal 'value'
…es are commented out? Hmm)
…sly works under "Deprecated" support)
…d rspec tests and fixed problems with worklog and comment not properly issuing their API endpoints under their respective parent. Needed to do a bit of work to the support shared example groups to fix how those supported the correct endpoint paths. Ugh.
Author
|
Not sure what else I need to do to get this reviewed/merged? Did I miss something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Jira Issue Properties.
Also had to address some issues with the Issue Worklog and Comment resources in that the collection endpoints were broken.
This also led to some changes in the spec shared example group to properly support the mock request/response for those endpoints.
This PR also addresses at least some aspects of the following issues:
worklogproperty infields#288we've had no problem retrieving worklogs - though the .all method was using the wrong request URL.
the problem was that Jira returns a 302 redirect for the attachment
note: we've been uploading attachments for years now without any problems. This PR allows the attachment name to be different from the source file's name (in our case, it is often a temporary filename).
There was not an issue for retrieving all comments on an issue (via
issue.comments.all) which was using the wrong request url - the url needs to be a path below the issue, not a top-level path.Finally, the unit test framework for building stubs and getting the mock was out of alignment. This allowed the comments and worklogs to "appear" to work correctly, when in fact they did not work with the actual API. This PR changes the shared example group to build an appropriate URI and then use that for both the stub_request AND getting the mock result.