Fix transition issue #358
Open
Fix transition issue #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating master from sumoheavy
Was using Grasshopper. Switched to using the newer agile API. Ran all RSpecs and they pass. Does away with the need to query rapidView.
I found two issues when trying to use jira-ruby to transition an issue: 1) The example provided in the example.rb file does not work. What one needs is a list of available transitions given the current state of the JIRA. issue.transitions.all does this. It provides an array that one can then look through to find the appropriate Id of the transition one wants to make. 2) Transition was using the default Base#save. However this does not generate the correct URL. It generates a URL in the form PUT https://jira-hostt/rest/api/2/issue/13322/transitions/34 with a JSON payload. What JIRA requires is a URL of the form: POST https://jira-hostt/rest/api/2/issue/13322/transitions with the correct JSON payload. This commit fixes this issue.
Contributor
|
Hi @trapeze-bell-peter , Unfortunately I am not familiar with this part of the JIRA API and would love to have some external reviews and/or people testing it. Could you also look into having tests for this change? |
Contributor
Author
|
Will add some tests and would welcome review. |
Contributor
Author
|
Just wanted to say sorry for not yet sorting out the tests. Been very busy. Hope to get to it this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found two issues when trying to use jira-ruby to transition an issue:
The example provided in the example.rb file does not work. What one needs
is a list of available transitions given the current state of the JIRA. issue.transitions.all does this. It provides an array that
one can then look through to find the appropriate Id of the transition one wants to make.
Transition was using the default Base#save. However this does not generate the correct URL. It generates a URL in the form PUT https://jira-hostt/rest/api/2/issue/13322/transitions/34 with a JSON payload. What JIRA requires is a URL of the form: POST https://jira-hostt/rest/api/2/issue/13322/transitions with the correct JSON payload. This commit fixes this issue.