Favourite filters for the user #350
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch: "filters" | Commit Type: "New feature" | Changes tested: "yes"
Contributor
|
Thank you for your contribution @scorpion35 ! Could you also add unit tests? |
Author
|
Apologies for the delay. I will add soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch: "filters" | Commit Type: "New feature" | Changes tested: "yes"
Use case: I would like to find favourite filters for the user (whomever's credentials are used to construct the client).
Tests: Pass (https://github.com/sumoheavy/jira-ruby/compare/master...scorpion35:filters?expand=1#commitcomment-37538721)
Let me know if you need more information please! Would like to get this merged as I think it might be useful to others as well 🙇♂️