Clean up some parts of the compose documentation #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Thank you for your contribution ! Your commits are "Unverified": Did you add your key in https://github.com/settings/keys ? |
|
@AntoLC I think I need to add my new email address to the GPG key (which only has the old one), and also re-import it to GitHub since it shows up as expired. Let me figure out how to do that. |
|
GitHub should also think it's verified now! |
|
Anything missing here still? |
|
Hi @z3ntu A merge commit has been added. I didn't know GitHub allowed us to push on a fork... Once made, ping me, and I will merge it. Thanks |
lunika
approved these changes
Aug 18, 2025
Signed-off-by: Luca Weiss <[email protected]>
Follow yamlllint's suggestions and use the correct indentation for lists. Signed-off-by: Luca Weiss <[email protected]>
It doesn't look like this is supposed to be there. Signed-off-by: Luca Weiss <[email protected]>
Signed-off-by: Luca Weiss <[email protected]>
Mostly give this as an example how a person deploying this knows which knob to turn. Signed-off-by: Luca Weiss <[email protected]>
|
@lunika Done! |
|
Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Clean up some parts of the compose documentation a bit which was added in #855.
CC @unteem
External contributions
Thank you for your contribution! 🎉
Please ensure the following items are checked before submitting your pull request:
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change)