emphasize babel plugin usage in the installation & getting started sections #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions Also removed a reference to bower since it's defunct.
|
This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push. |
19 tasks
mxstbr
reviewed
Aug 15, 2018
sections/homepage-getting-started.js
Outdated
| To download styled-components run \`npm install --save styled-components\`. | ||
| That's all you need to do, you are now ready to use it in your app! (yep, no build step needed 👌) | ||
| > It's highly recommended to also use the [styled-components babel plugin](https://github.com/styled-components/babel-plugin-styled-components). It offers many benefits like more legible class names, server-side rendering compatibility, smaller bundles, and more. |
Member
There was a problem hiding this comment.
Let's make sure to make it clear that it's not required, maybe something like
If you do have access to the build configuration and are using Babel it's recommended to use the styled-components babel plugin. (it is not required to use styled-components though, unless you're server-side rendering) It offers many benefits like more legible class names, server-side rendering compatibility, smaller bundles, and more.
Contributor
Author
|
No it IS recommended. We WANT people to use the plugin. It gives too many
benefits not to.
|
Member
|
A I brain farted, I meant is not required of course. Edited the comment, wdyt of my wording? |
Contributor
Author
|
@mxstbr done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed a reference to bower since it's defunct.