Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Conversation

@BewareMyPower
Copy link
Collaborator

This PR migrates #692 for master branch.

Since we will upgrade Pulsar to 2.9.0 later, which might bring more incompatibilities, this PR migrates the fix for branch-2.8.1 first.

@BewareMyPower
Copy link
Collaborator Author

BewareMyPower commented Sep 26, 2021

It looks like the KafkaAuthorizationTestBase is flaky, could you investigate this problem? @Demogorgon314

After you download the artifacts.zip, you can rerun the tests.

BTW, I think the quickest solution is only retaining one test of KafkaAuthorizationKafkaTest and KafkaAuthorizationPulsarTest since the formatter doesn't affect the authorization.

@Demogorgon314
Copy link
Member

Sure, I'll take look KafkaAuthorizationTestBase after solve the transaction tests.

@BewareMyPower BewareMyPower merged commit f7d67a5 into streamnative:master Sep 26, 2021
@BewareMyPower BewareMyPower deleted the bewaremypower/bump-2.8.1 branch September 26, 2021 11:05
BewareMyPower added a commit that referenced this pull request Dec 13, 2021
Fix the spotbugs check like what #692 and #746 did.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants